Carlos Vico Villalba

Results 11 comments of Carlos Vico Villalba

> I'd rather have the default be run3, and you revert to the old using `~run3` Thanks @vlimant for the suggestion. I don't have a feeling on what's the best...

> Hi @Cvico From the POG side we would like to take the opportunity to rename the variable from mvaTTH to mvaPrompt to unify the naming with what is used...

Hi, I've updated the name from `mvaTTH` to `promptMVA` as @JanFSchulte suggested, also in the `electrons_cff.py` config. I've checked it produces an output with two branches: `Electron_promptMVA` and `Muon_promptMVA`. I've...

Hi, comments addressed. I also spotted an issue in the Era Run3 modifier: since run2_muon_2018 was not being explicitly removed there, it was loading the Run 2 weights anyway... Should...

> > Should I also put run2_muon_2017 in that exclusion file? > > In what exclusion file? I was refering to the `Eras_Run3_cff.py` file where I explicitly excluded the 2018_muon...

> > I also spotted an issue in the Era Run3 modifier: since run2_muon_2018 was not being explicitly removed there, it was loading the Run 2 weights anyway... > >...

> > As for the effective areas for MiniISO, there is no retuning for Run 3, so we would need them to stay as they are for 2018 in all...

Small remark: I've changed the names of the files so it's more clear which variations are performed and I've also fixed a typo in one of the cards.

> Hi @Cvico, thanks a lot for this! bb4l is quite slow, so we probably do want to reduce the PDF sets similarly to what was done in UL. There,...

Hi, I've updated the PR with the PDF configs from Run2 UL gridpacks