Shi Chen

Results 151 comments of Shi Chen

The workflow is: 1. project imported 2. check corresponding jar in the classpath 3. if exists, update compile options at the server side since changing compile options needs re-compile to...

> My main concern was whether you did it here to avoid performance issues in the preferencesChanged callback, which shouldn't be doing heavy computations. Yeah, we can do things at...

@rgrunber I've tested it locally and it works very well 👍. I'm also following the PR in JDT side to enable it by default but it seems not so easily...

As for the choice about making it primary/secondary, there is a potential issue about quick fix when we just change secondary settings, if I'm a fan of `javax.annotations.*`, the quick...

> Does this avoid us having to create a setting for it ? IMO no. Let me draft a PR later.

The m2e issue https://github.com/eclipse-m2e/m2e-core/issues/842 is related to a different source level defined in the test scope. The current m2e might ignore this configuration and use that in compile scope only....

@foxpluto Is your project a Gradle project or not? And what's the value of your `java.import.gradle.enabled`?

IMO this issue is related to some out-of-sync metadata files of the project, please refer to https://github.com/microsoft/vscode-gradle/issues/1258#issuecomment-1211455418 to see if it works.

it seems the check happens in Gradle eclipse plugin: https://github.com/gradle/gradle/blob/dd350d3d50f7b7ea43f2a726739acb2c4645f30b/subprojects/ide/src/main/java/org/gradle/plugins/ide/eclipse/model/internal/SourceFoldersCreator.java#L163-L166

I remember @rgrunber mentioned this before: https://github.com/redhat-developer/vscode-java/issues/2285#issuecomment-1126151673 We have already updated to M2E 2.0, so is there any difference on size of the recent versions? Besides, we can have such...