Crypto Morin
Crypto Morin
Thank you for the detailed report. I briefly reviewed this. I'm just going to sum up the issues with the proposed solution: * The code will block the main thread...
findNMSVersionString() is an internal method, just like marked. It's not intended to retain its functionality in newer versions. If you for some reason use it directly and you have a...
I was thinking of changing the signature to: ```java class Property { boolean from(ItemStack item); } ``` Which is more cleaner without needing a separate method. Check the result and...
I agree there should be a way to manually remove properties. In that case, we can keep isDefault() but for manually removing, we should have: ```java class XItemBuilder { public...
You should cache `checkMetaAvailable` calls. E.g. it's done for `Durability` but not `BookAuthor` I'm not really a fan of the `isSupportedCached()` design. Just save them all as a simple boolean...
Any update on this?
Oh no worries, take your time.
Just to make sure, the summary of this post is: Add a way to create/edit hardcoded items that don't depend on YAML? I personally never had any use for this...
Duplicate code between XItemStack and XItemBuilder would be really rare and it'd be mostly because of compatibility if any. I just mentioned `XItemStack#recursiveMetaHandle` to point that even if duplicates due...
I really like your LambdaProperty solution since it uses method references that makes this almost zero-overhead. > Furthermore I don't think we should treat the Material as a property. Rather...