[XSkull] - Inconsistent behavior in different server versions & online/offline servers based on usernames and UUIDs

[Condordito]

Description

At the moment, applying textures does not work correctly in multiple versions. Each one has slightly different behaviors. This issue was previously discussed in another post, but no further details were given on the topic (#235)

1.12 (Online Server)

When applying a meta to an item stack, it generates the textures only if its GameProfile has a defined name or its UUID is stored in the server cache. Compared to the rest, the textures are applied synchronously, before being placed in an inventory

1.12.2 (Offline Mode)

Only textures applied via a cached UUID will be visible and stacked. None applied with a name are visible, but this is because SkullUtils.applySkinFromName skips these cases. They apply correctly otherwise

1.19.4 (Online Mode)

Textures from offline users will be applied on the next tick, causing them not to stack when placed in an inventory. As in 1.12, users with a non-cached UUID are not visible

1.19.4 (Offline Mode)

Textures applied with usernames are visible if the SkullUtils.applySkinFromName's UUID check is ignored, except when the user is logged in. If applied via UUID, the texture will be visible, but only if the server caches it and the user is offline

1.20.4 (Online Mode)

It works the same as in 1.19. The difference is that this throws an error if the UUID is not cached, since here it returns null for the offline player instance

1.20.4 (Offline Mode)

No textures are applied when using usernames, regardless of disabling SkullUtils.applySkinFromName checking for offline uuids

At first, I had in mind grabbing the server cache, as mentioned in #235, and then requesting an external API. However, this still maintains inconsistencies between versions and online/offline modes

Draft for how it could be handled (https://github.com/CryptoMorin/XSeries/commit/b69f315aa69ad57fbedb09702902fe748755b441)

It caches all textures but doesn't make those first requests asynchronous, blocking the main thread

1.12.2 (Offline Mode)

1.20.4 (Online Mode)

[CryptoMorin]

Thank you for the detailed report. I briefly reviewed this. I'm just going to sum up the issues with the proposed solution:

• The code will block the main thread for uncached values. This seems to be the case with the server's cache too in older versions. But it's kind of async in newer ones. I'm not really sure about that.
• The current code will not properly cache values in case of a temporary network issue (like timeouts) which can be fixed by either requesting again or not caching it and waiting for the next request.
• Even if all the above were fixed, this will double the server's memory, CPU and network usage when the same textures are requested from another plugin since we're keeping our own separate cache. I guess this can probably be fixed with some reflection hackery, but I don't think it's worth it.

Anyways, I've pushed some changes in https://github.com/CryptoMorin/XSeries/commit/421a61a85824056dbca2fcf2cbea59c85f84a6a7 based on your proposed solution. I also made UUID/OfflinePlayer requests compatible with offline mode servers.

[Condordito]

I made a PR to address those issues, but I'm unsure if XSeries should cache profiles when using base64 textures

• Other plugins may apply additional logic before caching, making XSeries caching redundant
• Recreating those profiles will not affect network usage or significantly consume CPU resources

Although less likely, I think it's not worth doubling memory usage when multiple plugins request the same texture