Eugene

net: signed-integer-overflow in LocalServiceInfo

3

`LocalServiceInfo` is defined as: https://github.com/bitcoin/bitcoin/blob/16781e1bc9f8ffc721ebea73434e0066957bc959/src/net.h#L228-L231 `nScore` is of type int which is signed and is 4 bytes wide on my machine (clang-12). `nScore` is incremented by `SeenLocal` during the version...

data race in SimpleRoundTripTest logging for macOS

1

**OS:** macOS 10.15.4 **Compiler:** brew installed clang-13 **Build command:** - `make clean; ./autogen.sh; CC=/usr/local/Cellar/llvm/13.0.1/bin/clang CXX=/usr/local/Cellar/llvm/13.0.1/bin/clang++ LDFLAGS="-fuse-ld=/usr/local/Cellar/llvm/bin/13.0.1/ld.lld" ./configure --disable-wallet --with-sanitizers=thread; make; make check` TSAN log ``` WARNING: ThreadSanitizer: data race (pid=85054)...

server+htlcswitch: check waiting-close fwdpkgs in reforwardResponses

1

Previously, the Switch would not check waiting-close channels' fwdpkgs for settles or fails to reforward. This could result in a force close in a rare edge case if a restart...

rpc: add alias info to some rpcs

3

- First commit adds a channel's aliases to `listchannels` and `closedchannels`. It also adds zero-conf information to these two calls. This includes the confirmed SCID for zero-conf channels and whether...

multi: add zeroconfacceptor to default reject incoming channels

3

Still need to write documentation about this. The zeroconfacceptor rejects all incoming channel open requests if we've specified the `--protocol.zero-conf` flag. This is for safety to ensure random nodes cannot...

funding: defer sending channel_update until received funding_locked

6

This is required by BOLT#07 as otherwise the counter-party will discard the channel_update as they may not consider the channel "ready" or reorg-safe. Most other implementations besides eclair have work-arounds...

lnd_test: fixing testGraphTopologyNotifications flake

11

This commit fixes a race condition where Alice's gossip filter would be set after the announcement generation between Bob & Carol resulting in Alice receiving no channel updates or node...

fuzz/tlv: harnesses to test equality, encoding+decoding

5

Uncovered one OOM a while ago. They were up on my local github though. Testing: ``` make fuzz-build pkg=tlv make fuzz-run pkg=tlv ``` Commits: - fix a false positive with...

multi: implement spec-compliant coop close

1

Implements https://github.com/lightning/bolts/pull/970 I want to split up the large htlcswitch+chancloser+peer commit, but since things are pretty intertwined I don't know how to do it. So leaving as draft for now....

replace ioutil.WriteFile usage with Fsync and friends

2

ioutil.WriteFile doesn't sync the data to disk, so any data written with this function can easily be lost. It's even possible that only partial writes happen. Issuing an Fsync is...