Eugene

Results 170 comments of Eugene
trafficstars

I would like to note that this is an "infinite" loop for three minutes

> I think another way to synchronize this would just be have it wait on the handleFundingLockedBarriers which was created in part for this purpose. We'd make the value a...

I added `NotifyWhenOnline` in `receivedFundingLocked` for when the peer is offline. What it doesn't handle is when the peer is online but hasn't sent funding_locked.

After this is in and tagged, we can update the call-sites to use either the p2p or non-p2p variant

> Why not update them here, or instead lave the default call be the P2P one and then have a new DecodeNonP2P etc? Only because I am not a pro...

> Is there a reason to go against best practice and use a bool, or do you also prefer an enum type? An enum is fine > Either way, it...

@Roasbeef Ideally yeah, I removed it since the board was getting cluttered. I can clean up this PR.