Results 149 comments of Eugene

I don't want this one to get lost since it's security-related so reopening it

Two small things I think we should mention here: - implementers need to be aware of a potential annex when extracting a preimage on-chain - where/when `SIGHASH_DEFAULT` is used. I...

v1 and greater outputs for coop close (e.g. no v0)?

> Hello all what are your thoughts on the `NextHeader` function. https://github.com/lightninglabs/neutrino/pull/285/files/e13c95fa3e76fd1883a8b2d0db0ba96a53b9b4c2..76952b79ac2a0c77450bc4dbd74275c325f5b1ef#diff-2345cea8b12f07d1f60d42b7e5563720e69e1544c641261cf147668c4599320bR3131 > > I say the function accepts an argument, n that would enable it fetch n headers at...

@goodwordalchemy did you get this working? This is what I get `gcc -shared dump.c -o dump.dylib Undefined symbols for architecture x86_64: "_pcap_write_header", referenced from: _patch_shn in dump-5720e5.o "_pcap_write_packet_header", referenced from:...

We don't need to make the htlc_maximum_msat bit required because that may cause newer LND nodes to disconnect from older nodes. We'll need to set the `dont_forward` bit in `funding/manager.go`...

Yup they need to be private for the flag to be set

> Related to the build cache. Going to put up a fix to reduce the cache size. @Crypt-iQ you self-requested review on this PR after 2 approvals. Should we block...

Just a note: one of the downsides of the disconnect race condition is that the RPC user that initiated the coop close won't be able to receive coop close updates...