Julien Gacon

Results 166 comments of Julien Gacon

I'm not sure that generating the matrix representation of the controlled gate and subsequently synthesizing the now larger matrix is efficient -- both are exponentially expensive in the number of...

Hi @josejad42, thanks for opening a PR! Could you give some more context to what you're suggesting, e.g. is there a reference that describes this simplification, and could you benchmark...

We currently don't optimize expressions containing parameter expressions, due to the overhead in handling the symbolic expressions. If the angles are bound, this should give the optimal decomposition, though, right?

For circuits, real is enough. But we currently also allow parameter expressions in the `SparsePauliOp`, where there's no restriction to real values. Beyond being more difficult to implement, complex number...

There are some very basic optimizations we ought to do in `PauliEvolutionGate.control` and `.power` to use the fact that we only have to control a single Pauli rotation to control...

As discussed offline I split the `iqp` function into `iqp` and `random_iqp` to have a separate function for the random generation of IQP circuits 🙂

069f45c added tests for the flagged lines in Coveralls (for the new functions, not for the existing classes), so I think we should have the 100% on that 🙂

Thanks for opening a PR to fix this! Could you add a release note and a test, to verify it now works as expected? (See e.g. [this PR](https://github.com/Qiskit/qiskit/pull/13181) for an...

The solution proposed in https://github.com/Qiskit/qiskit/issues/4149 which would just align all final measurements would also be nice, that way it is compact but we can still see the measurements.

I like the idea for the measurements -- if we add the bit we measure into to the measurement box, there's no information in the double vertical lines and we...