Julien Gacon
Julien Gacon
One additional comment about naming: the names of the synthesis classes, like `MCXSynthesisVChain`, seem a bit long to me now. That they are "synthesis" classes should be clear from the...
Yeah I agree "recursive" is not the best name, in particular since there are many schemes you could classify as recursive (see e.g. sections 7.2 and 7.3 in https://arxiv.org/pdf/quant-ph/9503016.pdf). Looking...
> One tricky complication (that I do not quite know how to resolve) is: given an MCX gate with some kind of a synthesis algorithm gate = MCXGate(num_control_qubits, some_synthesis_algo), what...
I'm not sure I remember the outcome of the last meeting correctly, but did we decide that it would be nicer if `UCGate.inverse()` would return a `UCGate` again? Maybe we...
Reproducing and checking the numbers from the circuit expressitivity paper is very interesting! However we're not quite sure how this contribution should be integrated to Qiskit yet. * _If_ we...
We discussed this in the team and it would be great to add the von Neumann and Meyer-Wallach entanglement measures to quantum info. There's an existing file `qiskit/quantum_info/states/measures.py` which already...
I think you could have the function accept both a statevector or a quantum circuit, since you anyways convert the circuit into a statevector, right? Something like ```python def von_neumann_entropy(data):...
Thanks for the PR @tyrolize! Could you also add the following translations, incl. tests: * `RYY` -> `RZZ` * `RXX` -> `RZZ` (this one is not automatically covered by the...
@tyrolize, are you still working on this? 🙂
I think both of these should be easy to construct with the `NLocal` ansatz. Is that also the one that you used in your code @epelaaez? 🙂