Federico Mariani

Results 17 comments of Federico Mariani

Hi, I'm not sure if this can be a solution but I created this POC https://github.com/Croway/jfrunit/tree/jfr-event-constants JfrUnitTest.shouldHaveGcAndSleepEvents contains the changes

yes, you are right, it's much better in this way, and I don't think it will be to hard to implement, in order to generate classes I created a simple...

Hi @gunnarmorling I implemented your first comment solution, JfrUnit should be backwards compatible with the older version (since I had failures with groovy tests), right now all test passes but...

Sure, I can move the generator into the JfrUnit project, I don't know what is the best practice for this use case, run the generator as part of the build,...

I have created an annotation processor, you are right, not 100% a use case, but it works, these are the branches https://github.com/Croway/jfrunit/tree/jfr-event-cons-annotation-proc and https://github.com/Croway/jfr-constants-generator/tree/annotation-processor I think that we can proceed...

Hi @gunnarmorling, I pushed new commits into https://github.com/Croway/jfrunit/tree/jfr-event-cons-annotation-proc - I have converted jfrunit to a multi-module project, I need some help with naming and poms (I'm not sure how the...

Hi @gunnarmorling, @danieledipompeo, I wanted to do the same and had the same error, I think it is due to jdk.internal.event module exposure is changed in jdk17, I managed to...

@danieledipompeo interesting, I tried it and it works, much more elegant compared to play with modules :smile: I came up with https://github.com/moditect/jfrunit/tree/add-extra-enforcer-rules-dep , too bad there are many dependency in...

> Ok, I can see what this PR does, but I am not quite sure how it makes any sense as a feature. Hello, I have an usecase (mostly due...

Thanks for the hint @cowtowncoder I have updated the PR.