Adam Pocock

Results 375 comments of Adam Pocock

Valhalla is adding value types & specialised generics to Java and is definitely still an active project. Panama is about making native interop easier, currently it's split into three parts,...

> after a sequence of changes, the exception handling is getting correct. however, before closing the issue we need to add some test cases ( which intentionally trigger exceptions )...

> > When I call `session.run` with a tensor with the incorrect shape I get the expected exception back and the JVM continues running. I think it's something about how...

> > Sure. The Java code in there looks a little odd, is there some guidance on which bits of the JDK I can expect to work? It looks like...

I made a PR with some new tests for the react-native portion #12659.

@yuslepukhin please could you review this PR? It's the last one to finish off the JNI refactor.

I can replicate that Windows failure locally, I get an error out of the JVM saying `The block at was not allocated by _aligned routines, use free()`. It's only the...

> > I can replicate that Windows failure locally, I get an error out of the JVM saying `The block at was not allocated by _aligned routines, use free()`. It's...

> > > > I can replicate that Windows failure locally, I get an error out of the JVM saying `The block at was not allocated by _aligned routines, use...

That TensorRT test failure looks independent of all the changes in this PR, it's in the core library tests rather than any of the Java ones.