Adam Pocock
Adam Pocock
> @Craigacp fyi The generated docs look good. There are a few missing docstrings as it's not pulling them in automatically from overridden methods in the JDK (e.g. places which...
Ok. I guess I should do a pass to add the `@since` tags and other things to the Javadoc. I can try adding the overview to see if it works.
Yes, I don't have time to do that this week.
> > This pull request **introduces 5 alerts** when merging [633c0b9](https://github.com/microsoft/onnxruntime/commit/633c0b9475121a1be8402e7f31c14bfccabc7c9c) into [0c6037b](https://github.com/microsoft/onnxruntime/commit/0c6037b5abe571fc43a55ef7a9d2f846820fbe5d) - [view on LGTM.com](https://lgtm.com/projects/g/microsoft/onnxruntime/rev/pr-f6192b6c34d254dc8eb2561c99185bdf5290189a) > > **new alerts:** > > > > * 5 for Uncontrolled data...
Oh, looks like the main branch was renamed from `master` to `main` so the target got a bit confused. I'll try to fix it.
I rebased on the new `main` and hopefully that fixed it.
I refactored the logic a little around where MSVC was complaining. Now it checks to see if there are too many inputs/outputs, if so it throws an exception, otherwise it...
> Please, rebase against the latest before I restart the CI builds. Done.
One issue with OpenJFX8 is that no-one is maintaining it. I think OpenJFX 11 is the earliest version that is being actively maintained.
Upgrading the jboss dependencies is the core issue, and I don't think it will be possible without extensive code changes as the jboss remoting package is very different between v2...