Craig Callender comments

Results 12 comments of


                                            Craig Callender

Solis Cloud Returning JSON with Trailing Commas

I raised it with them already (ticket 376560) - but I'm sure other reports wouldn't hurt. Here's what I sent so you can copy and paste: > Hi Solis Support...

Solis Cloud Returning JSON with Trailing Commas

@stevegal - Yep, I'll raise now. But I agree we should find less of a hack long-term. It looks like the JSON5 package in python will handle the trailing commas....

Ensure battery current limit is used in charge planning

@stevebuk1 - I think you're correct that I should have just used charger power instead of creating a new feature. It was just me not being familiar with the system,...

Integration with solis-sensor and solis-control

I'll work on it today and hopefully have it done tomorrow for review. :)

Integration with solis-sensor and solis-control

Thanks for the ping. I have it all working, but just haven't worked on the write up yet. Let me get on that...

Integration with solis-sensor and solis-control

@fboundy - Work gave us all a week to work on whatever we wanted to (hackathon). So I wanted to make some improvements. I finally got around to documenting this!...

[BUG] fossil_fuel_percentage entity value is swapped (or documentation is wrong)

I just noticed the same issue and can confirm here too.

Replace deprecated aliases HomeAssistantType and ServiceCallType

Thanks for this @rneubert. I literally came here to submit my own PR for this and found yours. :)

Codebase as context only picked up one source files

I am also seeing this in VSCode.

Local Storage Binding: List Operation Give Full Paths, Get Operation Expects Relative Paths

I opened this up in the wrong repo - but here's the original report: https://github.com/dapr/dapr/issues/8869