CrabSAMA

Results 13 comments of CrabSAMA

@dosu Here is my research: this line actually incorrect: https://github.com/langgenius/dify/blob/9843fec3931ba791b09a3805e44fbe6636191996/api/core/workflow/nodes/parameter_extractor/parameter_extractor_node.py#L543 If parameter extraction node have some non-required parameter, because of `result` field is extract by model, and prompt did not...

> I am wondering if your code can also be applicable to custom tools or other tools which are published in the Marketplace? Actually the outputs of all of these...

> Hello, please fix the lint errors in the CI @CrabSAMA > > This PR LGTM. @crazywoola Uhh, this CI API Test fail error does not seem to be introduced...

Sorry for my wrong opinion earlier, the unit test really have problem, and now I fixed it and the CI will run successfully. And then please review this pr when...

@Nov1c444 About auto-generating the output schema, it have some problem currently. At first I try to resolve the problem about same name with reserved field: > Because of current feature...

I got your opinion😄, actually at first I also think about make this feature with backend, let `output_schema` return dynamic, and I face some problem, but indeed time has passed...

@crazywoola hey, what should we do next in this PR? I have passed the CI, do I need to perform any further actions?

@crazywoola @Nov1c444 Hello, I try to refactor this feature as comment said, it actually have better experience! Maybe we can review the change now, thank.