Adam Crabtree

Don't mutate/use passport.authenticate options object

3

It seems that reusing an options object causes very bizarre very difficult to debug bugs. I haven't looked at the code, but I feel pretty confident it's because the options...

## Pre-Submission Checklist - [x] Ran the linter and tests via `make prepush` - [x] Included comprehensive and convincing tests for changes ## Issues > Summarize the issues that discussed...

Especially readdirRecursive.

NG should be idiomatic JavaScript

31

With ESNext, there's a whole suite of new functionality previously provided by core. Given the opportunity for breaking changes, NG should strive to be idiomatic JavaScript in all regards (**EDIT:**...

Install fail

10

UPDATE: This appears to only work when executed from git repo's root folder, otherwise I get the Java error below. ~/cpm$ cpm # Works ~/cpm$ cpm install dojo ~/cpm$ cd...

Add `Promise` API (Bonus: finally support)

6

An opt-in `Promise` API is the best avenue for adding finally support. Likely, the callback API will be deprecated at a point that makes sense and avoids as much inconvenience...

Separate guarding functionality into base module

2

There are 4 parts to trycatch: - Fixing callback context (EE handlers at time of listen vs at construction) - Guarding core from userland errors and fixing - Long-stack-traces -...

And Error.create for convenience. Something like... ``` javascript trycatch(function() { ... }, [EvalError], function(err) { // only catch EvalError }) ```