Counterfeiter

success in ReadFile isn't handled properly

1

Hi, in this line: https://github.com/mikeobrien/HidLibrary/blob/master/src/HidLibrary/HidDevice.cs#L615 success is checked. If success is true, the ReadStatus issn't set to Success . Function exits with NoDataRead, but valid data could be read. Maybe...

Add hidden states for games

1

With this change games with hidden information per player could be implemented. The hash function that represents the game state is now part of the game to add also hidden...

Hello, would be great to test this. I have implemented a more complex board game: https://github.com/Counterfeiter/KingdomBuilder I made a gym env wrapper... but not pushed at the moment. An Issue...

Works great to make decisions about quality of the face to pass forward or not to arcface (get facial embeddings). Please add a license so everybody could reference your work...

Sigma value is not Gauss sigma it is FWHM

7

Hello, there is a small bug, that confused me... Your sigma value is FWHM not Gauss sigma. You convert FWHM to sigma here: https://github.com/WeisongZhao/sparse-deconv-py/blob/88c367a678048f7207392de91d550f6c1a1d6263/sparse_recon/iterative_deconv/kernel.py#L15 I'm an amateur astronomer, I tested...