Glenn Smith
Glenn Smith
Thanks for the optimization tricks! Glad to see other people have had similar ideas-- it seemed pretty obvious when I wrote it. I'll have to look into caching SHA1 state...
I've started an implementation of this, but ran into a couple bugs as mentioned in [that PR](https://github.com/decompiler-explorer/decompiler-explorer/pull/73). If y'all want to address them (or just release as-is) go ahead-- I'll...
The progress function only keeps the ui responsive if it's called often enough, and for larger bndbs this is not the case. Eg ntdll can spend multiple seconds generating the...
PDBs now properly annotate `this` parameters and thiscall functions, so combining the fixing of #604 with the new PDB loader in 3.1.3715-dev, this is now fixed.
Here are a couple more I just found: ``` ?MyBase_firstFunction@MySubClass@@$4PPPPPPPM@DA@EAAXXZ ==> ([thunk]:public: virtual void __cdecl MySubClass::MyBase_firstFunction`vtordisp{4294967292,48}' (void) __ptr64) ??_EMySubClass@@$4PPPPPPPM@DA@EAAPEAXI@Z ==> ([thunk]:public: virtual void * __ptr64 __cdecl MySubClass::`vector deleting destructor'`vtordisp{4294967292,48}' (unsigned...
Here's another one that is wrong and messy: ?describe@CatDog@@$4PPPPPPPM@DI@BEXXZ ==> [thunk]:public: virtual void __thiscall CatDog::describe`vtordisp{4294967292,56}' (void)const And one that binja doesn't get at all: ??_R0?AU?$DelegateMethod@PAVTelnetConsole@@P81@AEXXZ@?$Signal@UEmptyType@@U1@U1@U1@U1@U1@U1@U1@@@@8 ==> struct Signal::DelegateMethod `RTTI Type...
These have been re-run but one of the angr runs still timed out. Disabling timeouts on samples is an interesting question of performance reporting, and I'm not sure about it.
CC https://github.com/fkie-cad/dewolf/issues/95
Integration now just blocking on rebase + updating remote binja to 3.1.3615-dev
Good to hear about your release @steffenenders, I'll update this PR when I get a chance. Haven't had much time to look at this PR recently due to the upcoming...