Xinyu Hu

Results 5 comments of Xinyu Hu

Checking the input parameters (address and size) is another matter, here we should make sure that `address>=0` and `size>0`; Assuming a correct parameter input, if we do not subtract 1...

> [@zhhyu7](https://github.com/zhhyu7) I think we have two ways to fix it, which way do you think is better? > > 1. Don't allow choosing `icmp->id` as `0`, that is, return...

> > > [@zhhyu7](https://github.com/zhhyu7) I think we have two ways to fix it, which way do you think is better? > > > > > > 1. Don't allow choosing...

> [@CosmicRoach](https://github.com/CosmicRoach) could you create PR to fix it? Okay, I will create a PR.

> [@CosmicRoach](https://github.com/CosmicRoach) could you create PR to fix it? Although our ideas are meaningful, after careful consideration and attempts at modification, this may not pose an issue: - As an...