CorinJG comments

Results 5 comments of


                                            CorinJG

Implement socket options struct and builder for socket with options

Was about to create new issue for ability to specify socket's identity - right now PeerIdentities are by uuid only. But I guess this falls under the builder issue.

Implement socket options struct and builder for socket with options

Looks pretty functional to me, can perform userspace routing now - Thanks!

Implement socket options struct and builder for socket with options

That's very kind of you, thanks a lot:)

Implement socket options struct and builder for socket with options

I could be wrong but I can't see that TCP Nagle is disabled anywhere in the lib (eg. simply at socket creation via [set_nodelay](https://docs.rs/tokio/1.2.0/tokio/net/struct.TcpStream.html#method.set_nodelay)) - `tokio::net::TcpStream` sockets enable Nagle by...

Implement socket options struct and builder for socket with options

@Alexei-Kornienko Yes that's sensible, looks like it's part of the ZeroMQ [protocol](https://en.wikipedia.org/wiki/Talk%3AZeroMQ) so shouldn't be a socket option.