Copilot

Results 4897 comments of Copilot

@charlesroddie I've opened a new pull request, #242, to work on those changes. Once the pull request is ready, I'll request review from you.

Just as a heads up, I was blocked by some firewall rules while working on your feedback. Expand below for details. > [!WARNING] > > > Firewall rules blocked me...

> @copilot test/Orleans.Persistence.TestKit.Tests/MemoryGrainStorageTests.cs:35 > The test names should match the underlying test implementation. Updated all test method names to match the base implementation. Changes in commit f1afce9.

> @copilot Scan the codebase for existing IGrainStorage tests and ensure that this new test kit includes coverage for all of the existing scenarios Scanned existing IGrainStorage tests (CommonStorageTests, RelationalStorageTests,...

> @copilot Find missing tests and add them. The GrainStorageTestRunner tests looks like it doesn't have as many tests as I would expect. What other tests should be added? We...

> @copilot CI is failing, fix issues Fixed CI failures in commit 162c0a3: - Added Node 20 compatibility by using glob package as fallback when fs.globSync is unavailable - Fixed...

> @copilot please fix @domoritz reviews. Do not use glob. It it fails for you, means your node is outdated. Fixed all review comments in commit c646d44: - Removed glob...

> @copilot please use a semantic pull request title like fix: ... The PR commits will be squashed on merge. The suggested semantic commit message for the squashed commit would...

> @copilot Make the necessary changes to make the newly added baseline tests pass. The baseline tests are already passing. Verified by running: - `cargo test --package gix-date` - All...

> @copilot fix CI by updating the `tar` file - it must be committed as well after running the tests locally (which changes it once the corresponding shell script changes)....