CSharpMath icon indicating copy to clipboard operation
CSharpMath copied to clipboard
verified publisher icon verybadcat

Workflows update

Open charlesroddie opened this issue 3 months ago • 5 comments

  • Update versions in workflows
  • Remove a workaround which breaks the build
  • Remove IOS projects as per https://github.com/verybadcat/CSharpMath/issues/231
  • Remove WPF Forms example which doesn't build any more

Fixes https://github.com/verybadcat/CSharpMath/issues/231

charlesroddie avatar Dec 12 '25 02:12 charlesroddie

Should be mergeable once CI passes.

Happypig375 avatar Dec 12 '25 03:12 Happypig375

@copilot There are projects in this repo which target xamarin ios, e.g. xamarin.ios1.0, which is deprecated and doesn't work with modern tooling. At present I'm interested only in the projects in the iOS solution folder: CSharpMath.Ios, CSharpMath.Ios.Example, and CSharpMath.Ios.Tests. These should to be updated to a modern version of dotnet ios, ideally net10.0-ios. Can you try to do that and open a PR into this branch?

charlesroddie avatar Dec 12 '25 10:12 charlesroddie

@charlesroddie I've opened a new pull request, #241, to work on those changes. Once the pull request is ready, I'll request review from you.

Copilot avatar Dec 12 '25 10:12 Copilot

@copilot the fact that the wiki is a submodule is a problem. It prevents committing from VS or git locally and is causing the current build failures. Can you remove the submodule from the git configuration of this project and check in the files directly?

charlesroddie avatar Dec 13 '25 10:12 charlesroddie

@charlesroddie I've opened a new pull request, #242, to work on those changes. Once the pull request is ready, I'll request review from you.

Copilot avatar Dec 13 '25 10:12 Copilot

Avalonia: either we disable tests, or wait for Avalonia v12 preview which will move to SkiaSharp 3.0. I think we should leave this until Avalonia v12 preview which should come out in the next 2 weeks.

Aside from Avalonia everything is now in a passing state, but the releases haven't been tried.

Likely status of releases is: CSharpMath, CSharpMath.Editor, CSharpMath.Evaluation, CSharpMath.Rendering, CSharpMath.SkiaSharp: OK CSharpMath.Avalonia: OK with v12 CSharpMath.Forms: likely non-working.

The Forms projects should be deleted as Forms is obsolete. But it could also be updated to MAUI. I suggest giving giving Copilot a task to update Forms to Maui, and if it succeeds merge it, and if it fails delete Maui. Unless anyone wants to devote human effort to the update? Reasonable @Happypig375 @FoggyFinder ?

charlesroddie avatar Dec 15 '25 11:12 charlesroddie

I'll do the MAUI port.

Happypig375 avatar Dec 15 '25 11:12 Happypig375

Added MAUI, pending complete Forms Example port and Tests

Happypig375 avatar Dec 15 '25 21:12 Happypig375

I'll merge #121 #215 and #222 into this PR if you don't mind.

Happypig375 avatar Dec 16 '25 11:12 Happypig375

OK (but could also wait 2 weeks and go in separately):

  • VectSharp because it's a way to generate vector graphics which this repo doesn't have atm. Also at +272 −0 it's very code-efficient.
  • Update badge.

The Uno PR I don't support for reasons given in the PR (I would have a 10-line "how to use in Uno" guide on the front page instead of +4,326 −31) but if there is a majority it can go through. But not in this PR please. This PR should go thorugh in the next 2 weeks with Avalonia 12 preview and that will unblock the PR process.

I'm thinking we need a version bump to 0.6.0-preview, because there are big package updates and removals of support for Forms and anything not compatible with SkiaSharp 3.0, and Avalonia will support the preview version of Avalonia.

charlesroddie avatar Dec 16 '25 12:12 charlesroddie