Consolatis
Consolatis
What is left in this PR, mostly rounded corners?
> We have several wlr_output_* functions which are just wrappers around corresponding wlr_output_state_* functions and don't actually touch the wlr_output itself. These probably made some sense historically, They were added...
> It also reminds me that I would like to create an `output.h` rather than having all the `output` functions in `labwc.h`. Anything that shrinks `labwc.h` is a good thing...
Did we additionally break anything or is it just the wlroots change? If its just the wlroots change I think the best option is to figure out a way to...
> Perhaps we should remember the focused surface on lock then restore it on unlock. That sounds sensible to me. However we need to ensure that the surface still exists...
> Compositor doesn't support moving popups I think that requires a newer version of some xdg protocol. As far as I remember, wlroots supports that one since 0.17.x but I...
Right, especially https://gitlab.freedesktop.org/wayland/wayland-protocols/-/blob/main/stable/xdg-shell/xdg-shell.xml?ref_type=heads#L1330
> Why not go to version 6 of xdg-shell? There are some interesting additions to the 5,6 level As long as we (or wlroots internally) handle all the individual changes,...
Hm.. we do move layershell popups to their own popup tree per output that is positioned above the "overlay" tree (but below the session-lock tree): https://github.com/labwc/labwc/blob/1495708095b998f03aa8f07a6796764981e2dcd6/src/layers.c#L436-L457 (note: the comment above...
> I think it's another topic. Dialogs can be decorated (e.g. confirmation dialog shown on quitting QTerminal) so popups are not suitable for this. Whoops, somehow missed this comment: >...