Conrad Irwin comments

Results 605 comments of


                                            Conrad Irwin

Action release handlers

@alygin do you want to push up the work we did today to this branch or close this one and send another?

Action release handlers

Thanks!

Zed crashes if it can't load a grammar

We’ve fixed several instances of this over the last few weeks. Closing for now but please reopen if you can still crash zed with a bad grammar.

Expired signatures break dotgpg

@viraptor There is a workaround you can use: ``` DOTGPG_ALLOW_INJECTION_ATTACKS=true dotgpg edit ... ``` Not sure what the usual way of handling this situation is with other crypto tools?

Improve logic for obtaining surrounds range in Vim mode

That's roughly what I ended up doing everywhere else, so seems fine. You still need to handle the edge-case at the start of the buffer, etc. Alternatively you can keep...

Improve logic for obtaining surrounds range in Vim mode

Thanks!

Clear credentials state and delete keychain on SignOut request

@pedrosoares Thanks for this! I think we should have a separate method on client for this that is called `fn sign_out`. That would clear the credentials and keychain, and then...

Clear credentials state and delete keychain on SignOut request

Thanks! I made a small tweak to ensure the disconnect happens quickly so the UI feels responsive, and will merge when CI is green.

Delete a Gist

I'd happily accept a pull request that added: `gist --delete [ URL | ID ]` In the same way that we currently support `--update`. I don't think it needs a...

Clipboard use

Sure, should be an easy pull request ;)