zed
zed copied to clipboard
Clear credentials state and delete keychain on SignOut request
@pedrosoares Thanks for this!
I think we should have a separate method on client for this that is called fn sign_out
. That would clear the credentials and keychain, and then call disconnect.
If you'd like help getting this over the line: https://calendly.com/conradirwin/pairing
@pedrosoares Thanks for this!
I think we should have a separate method on client for this that is called
fn sign_out
. That would clear the credentials and keychain, and then call disconnect.If you'd like help getting this over the line: https://calendly.com/conradirwin/pairing
@ConradIrwin No problem.
~Just to be clear, i should create a method called fn sign_out
and call-it on the disconect method? Could be this method async and handle the block_on on the disconect method?~
I just re-read your comment and misinterpreted it 😅, i'm gonna edit and update the PR.
Thanks! I made a small tweak to ensure the disconnect happens quickly so the UI feels responsive, and will merge when CI is green.