zed icon indicating copy to clipboard operation
zed copied to clipboard

Clear credentials state and delete keychain on SignOut request

Open pedrosoares opened this issue 10 months ago • 2 comments

Release Notes:

pedrosoares avatar Apr 15 '24 14:04 pedrosoares

@pedrosoares Thanks for this!

I think we should have a separate method on client for this that is called fn sign_out. That would clear the credentials and keychain, and then call disconnect.

If you'd like help getting this over the line: https://calendly.com/conradirwin/pairing

ConradIrwin avatar Apr 15 '24 20:04 ConradIrwin

@pedrosoares Thanks for this!

I think we should have a separate method on client for this that is called fn sign_out. That would clear the credentials and keychain, and then call disconnect.

If you'd like help getting this over the line: https://calendly.com/conradirwin/pairing

@ConradIrwin No problem.

~Just to be clear, i should create a method called fn sign_out and call-it on the disconect method? Could be this method async and handle the block_on on the disconect method?~

I just re-read your comment and misinterpreted it 😅, i'm gonna edit and update the PR.

pedrosoares avatar Apr 16 '24 12:04 pedrosoares

Thanks! I made a small tweak to ensure the disconnect happens quickly so the UI feels responsive, and will merge when CI is green.

ConradIrwin avatar Apr 17 '24 01:04 ConradIrwin