Connor Gray comments

Results 65 comments of


                                            Connor Gray

Add serialization support for simple types

@oovm Thank you again for submitting this contribution. I hope my suggestion that we put this behind a non-default unstable Cargo flag is a reasonable compromise for the time being,...

Questions about `ExprKind`

> why do I need ExprKind, can E be any other structure? This dates back to 3fdd73d, which added an `ArcExpr` alternative to `Expr`. The problem was (and still is)...

[stdlib] Make trait `CollectionElement` inherit from `ExplicitlyCopyable`

!sync

[stdlib] Make trait `CollectionElement` inherit from `ExplicitlyCopyable`

!sync

[stdlib] Use `InlineArray[UnsafeMaybeUninitialized[T], size]()`

Mojo recently gained support for custom `self` types in `__init__` methods, so I wonder if we could write this now as: ``` struct InlineArray[..](..): fn __init__[T: CollectionElement]( inout self: InlineArray[UnsafeMaybeUninitialized[T]]...

[stdlib] Use `InlineArray[UnsafeMaybeUninitialized[T], size]()`

I've just merged #3119, so I think we're finally ready to move forward with this PR🙂 Thanks for your patience Gabriel as we've worked this through some internal hurdles, its...

[mojo-stdlib][docs] Update docs and code to use `from <module> import <entity>` instead of `from <module>.<file> import <entity>`

Hi Farhan, thanks for running that formatting change. From reading the CI failure above, it looks like your branch may still be using an older version of the Mojo compiler....

[mojo-stdlib][docs] Update docs and code to use `from <module> import <entity>` instead of `from <module>.<file> import <entity>`

Hi Farhan, thanks for trying that. I haven't used `git pull --rebase` myself, but from reading about it, it looks reasonable. However, I noticed that the [list of commits for...

[mojo-stdlib][docs] Update docs and code to use `from <module> import <entity>` instead of `from <module>.<file> import <entity>`

Amazing, thank you Farhan for working through those git issues🙂 I know that's nobodies favorite kind of work. Regarding the formatting, it looks like you're running into a known issue...

[mojo-stdlib][docs] Update docs and code to use `from <module> import <entity>` instead of `from <module>.<file> import <entity>`

Amazing, thanks for fixing the formatting Farhan. Unfortunately, the last remaining issue is that each commit needs to include the `Signed-off-by` section. For this particular PR, you can add automatically...