Connor Gray comments

Results 65 comments of


                                            Connor Gray

[stdlib] Remove some `# CHECK` and refactor `test_print.mojo`

**✅🟣 This contribution has been merged 🟣✅** Hi @gabrieldemarmiesse thanks for this contribution, and updating all of your PRs! As mentioned, we're moving to a new infrastructure for merging contributions...

[stdlib] Move `unsafe_pointer.mojo` off `LegacyPointer`.

Thanks for tackling this @soraros! 🙂 It looks like may need to be rebased to fix a merge conflict, and also update the compiler version as we just released a...

[stdlib] Refactor uses of `StaticTuple` to use `InlineArray`

Hi @artemiogr97, re. your second question: > in collections.vector, utils.inlined_string StaticTuple is instantiated with uninitialized values which is forbidden for InlinedArray Yes, it would be good for us to preserve...

[stdlib] Support print to stderr

Thanks for working on this @GeauxEric!🙂 I left a couple of small suggestions, but I noticed this PR is still in 'Draft' mode, so I'll hold off on leaving any...

[stdlib] Refactor slice to use Optionals and fix negative step slices

Thanks for taking this on @bgreni! It's awesome to see us using types like `Optional` to make APIs like this more precise and ergonomic 😄

[stdlib] Optional `start` and `length` arg for `String._strref_dangerous`

@fknfilewalker Thanks for your work on this so far. Regarding whether we want to move forward with this, I think at the moment this change seems a bit under-motivated. From...

[stdlib] Add the `normalize_index` function

Now that this has been merged, we should start using it more widely. @gabrieldemarmiesse @laszlokindrat is there any reason I might have missed that means I should hold off on...

[stdlib] Add the `normalize_index` function

Thanks Gabriel. Filed https://github.com/modularml/mojo/issues/2948 to track this. From grepping through the stdlib code it looks like there aren't that many uses of this pattern overall, so the size of resulting...

[stdlib] Add equality methods to Span

!sync

Add serialization support for simple types

@oovm I appreciate you taking the time to prepare a PR with an important feature such as this, thank you for this contribution! I do have some hesitation about the...