Connor comments

Results 181 comments of


                                            Connor

Update README about forking RocksDB or submit patches upstream?

As we have done a lot of changes, I can't see we can use vanilla upstream RocksDB in near future.

Update README about forking RocksDB or submit patches upstream?

Yes, some changes are already merged in upstream

Questions regarding how beginners can understand the detailed design related to garbage collection in the Titan source code.

There is no detailed design for `FileState`. For `kPendingLSM`, the blob file is created during flush. For `kPendingGC`, the blob file is created during GC,

BlobIndex will be broken and failed to decode when zero-terminated in blob handle in compaction filter

Yes, seems should use `value` directly. Would you like to fix it?

Region is applying snapshot for a long time

It is better to add metrics to know the pending ingested snapshot count

Region is applying snapshot for a long time

/assign @hbisheng

schedule: reject transfer leader if apply is busy on store start

> I think we need a triage to merge this PR. It's not a bugfix, and no need to be merged into 6.0. Now basing on 6.0 is just handy...

*: Update rust toolchain to nightly-2024-08-29 to use faster linker

/release

*: Update rust toolchain to nightly-2024-08-29 to use faster linker

> Can you provide the comparison results of this change regarding the reduction of compilation time? Additionally, if there are performance testing results available to demonstrate that this change does...

Commit log duration is high when hibernate regions are awake

@rleungx It's due to too many messages sent by these regions when they want to be hibernated again which blocks heartbeat/append messages being sent in time. But why restarting PD...