Connor comments

Results 181 comments of


                                            Connor

1.0.23 <C-o> <C-i> not working

live-blob-size is much larger than total size of blob file

No progress. You can take a look. I guess it's due to the encoded value is in compression.

Consider removing blob index deletion marker

So the API support type changes, but the rocksdb implementation is not supported yet. Got it.

Waste too much time on blob cache operation

Yes, but seems the mutex contention causes too much overhead. And in 4.0 branch, it doesn't have that much overhead when size == 0. I'll take a deep look in...

Restrict buffered value size for blob zstd dictionary compression

/cc @yiwu-arbug

Rewrite valid keys by ingesting SST files during GC

The benchmark of https://github.com/tikv/titan/pull/121 shows Ingest may hurt read performance, see ``` dbbench (./titandb_bench --key_size="16" --value_size="256" --cache_size="4294967296" --titan_min_blob_size="0" --num="10000000" --numdistinct="10000" --benchmarks="fillseq,overwrite,readrandom" --threads="6" --titan_max_background_gc="6"): gc_rewrite_mode = kDefault fillseq: 99.3 MB/s; overwrite:...

In BlobGCJob::DoRunGC(), the `file_size` is always = 0.

Nice catch. Yes, the code is missing. Would you like to fix it?

YCSB help

YCSB can't test Titan directly. You can use ycsb to test TiKV with Titan enabled.

Titan support write without WAL

Seems the GC rewritten index suffers the same issue. The new blob index is still in memtable when db restart, then old blob index is exposed but the blob file...

Reduce locking for blob cache hit queries

> I built the titan on the version in the demo, with rocksdb version 6.4.tikv. > > > ./titandb_bench --db="/dev/shm/titan_bench" --use_existing_db=false --titan_min_blob_size=0 --value_size=1024 --num=10000000 --compression_type=none --benchmarks="fillseq" > > Then I...