Yifei Zhang

Results 90 comments of Yifei Zhang

Thanks for your work @gy95 . >Do we need a svc to post some api to this component? Currently, the controller manager does not expose any api for service. I'm...

I'm not sure if we could set the image tag through `--set controllerManager.image.tag=v1.10.0-beta.0-264-g315c619`. I tried this , but the image tag for the controller-manager was still `v1.10.0`. The command is:...

Because of moving comments of devices from [register.go](https://github.com/kubeedge/kubeedge/blob/7c625350ef5a713f29a24ef3642af3644f4aa1d0/pkg/apis/devices/v1alpha2/register.go#L20-L24) into [doc.go](https://github.com/kubeedge/kubeedge/blob/4831024e53dcb89a191f92a7178e72e1fa92efbe/pkg/apis/devices/v1alpha2/doc.go#L18-L22), other generated code also be corrected, including: - [pkg/client/clientset/versioned/typed/devices/v1alpha2/devices_client.go](https://github.com/kubeedge/kubeedge/pull/4017/files#diff-52cb59a22f02dfba5a708df61cc7e684f3f9c0942e7b618cc875818694ae32c4) - [pkg/client/clientset/versioned/typed/devices/v1alpha2/fake/fake_device.go](https://github.com/kubeedge/kubeedge/pull/4017/files#diff-8b05389f91f9eac14c34f1666d774b1b22dcb1f92e7e8c7344443c0679ee583e) - [pkg/client/clientset/versioned/typed/devices/v1alpha2/fake/fake_devicemodel.go](https://github.com/kubeedge/kubeedge/pull/4017/files#diff-a6edcfbfc479f33b1b1499aa31a4e92d912a3b635f33f4dab65fb9236d14cfda) - [pkg/client/informers/externalversions/generic.go](https://github.com/kubeedge/kubeedge/pull/4017/files#diff-d015eca2cbf61eb2a0e76424065c0abbc45e8cdc45d526cca9bba6a8c800154c) The group of devices are...

Thanks for your contribution, I'll take a look.

@rambohe-ch Sounds good, it can simplify the logic in CacheManager. Since proxyServer and yurthub server listen at different port, it may need another redirection in local proxy. And for `apps/discovery.k8s.io/v1`,...

>@Congrool we need to add new handler for ProxyServer not yurthub server. and apps/discovery.k8s.io/v1 and apps/discovery.k8s.io/v1beta1 are needed for CoreDNS startup. Well, I mean all requests from edge will be...

By the way, if we handle `/version` in yurthub server, it's somewhere counterintuitive. If some client visit the `/version` of yurthub server, it may expect to get the version info...

OK, my misundertanding😢. agree+1

I think the disscussion above means to add a new http handler for proxy server to handle `/version` request. Something like: ```go mux := http.NewServeMux() mux.HandleFunc("/version", versionHandleFunc) mux.HandleFunc("/apis/discovery.k8s.io/v1", discoveryFunc) ......