Xianyang Liu
Xianyang Liu
Hi @rdblue, thanks for the review. I have reverted the changes for the writers. Please take another look, thanks a lot.
A little busy recently. Will address the comments tomorrow.
Thanks, @rdblue @szehon-ho for the review. Comments have been addressed.
> I wonder, is it possible to add a test to try to deserialize an older manifest entry without schema_id? It seems to need to implement customized V1Writer/V2Writer and those...
Thanks @szehon-ho for the review and suggestion. > Maybe a test writer that creates metadata files with all optional columns as null? That way can test all the new columns...
Hi @rdblue @szehon-ho, I am sorry for the late update. The compatible test has been added. Hopeful, you could take another look when you are free.
Hi @szehon-ho thanks for reviewing this again. > Also I noticed, spec-id and schema is already written in the header of each manifest. As far as I can tell, it...
> I think the situation would be the same even in your proposal to add new schemaid field to data_file, right? After rewriteDataFiles we have to carry over the latest...
Hi, @huaxingao @rdblue @kbendick . Could you help to review this when you are free? Thanks a lot.
Thanks @rdblue @kbendick @zhongyujiang @huaxingao for your time to review. Comments have been addressed. Pls take another look when you are free.