David

would you prefer those `new_text` strings as `G_settings and x or y` or `if G_settings then x else y end`?

just noticed some [potential] shenanigans with dispatcher and custom shortcuts, updating now...

It is unlikely that anyone will ever see this (you can only get here through dispatcher, on NT), but then again there are some 'very bad boys' out there. I...

> And translators will see it. spooky. Seriously though, why is that a problem? > Just do it for him, and if you want, tell him this was done (so,...

how about something like ```lua elseif side == "right" then if G_reader_settings:isTrue("input_invert_page_turn_keys") then G_reader_settings:makeFalse("input_invert_page_turn_keys") Device:invertButtons() end G_reader_settings:flipNilOrFalse("input_invert_right_page_turn_keys") Device:invertButtonsRight() if G_reader_settings:isTrue("input_invert_right_page_turn_keys") then new_text = _("Right-side page-turn buttons inverted.") else new_text =...

> What changed since I previously approved it? you could invert an already inverted state and cause mayhem. it is better handled now. here onwards https://github.com/koreader/koreader/pull/12424#issuecomment-2334922459 oops, you actually approved...

Is anything else missing here?

> @Commodore64user Congrats on merging! thanks! > Can you please explain how this PR works? sure. It is a lot less exciting than the title makes it sound though. >...

> (which may be somewhat new yes, fresh out of the oven #12249. Although I originally only intended to use it for physical page turn inversions, @poire-z strongly suggested ;)...

hey @NiLuJe I was going to test loading a large 70+ MB ebook to see how the K4 handles it but was greeted with a "Full storage" warning but --I...