Iaroslav Postovalov

Results 48 comments of Iaroslav Postovalov

Off topic.

> Example 2, non-sealed class, can transform object equality to identity equality: This is incorrect, because `x` may be something like: ```kotlin class WrongN : N(42) { override fun equals(other:...

@udalov since the pass works only if the affected sealed class is in the same module with the call site, no special tests for incremental compilation are needed, aren't they?

> Incremental compilation is a subsystem that works within one module, and it allows to avoid recompiling the whole module (= pass all source files of the module to the...

> No, I still have the concern discussed above: [#4496 (comment)](https://github.com/JetBrains/kotlin/pull/4496#issuecomment-878329065) > > Incremental compilation is a subsystem that works within one module, and it allows to avoid recompiling the...

> Yes, you can. You can use java-gradle-plugin plugin like it is done [here](https://github.com/mipt-npm/gradle-tools/blob/138ee1cfeaf2e80e07eec0a85288ab328f48b21e/build.gradle.kts#L4). It will make all plugin management tweaking unnecessary. This is already done by the kosogor plugin.

(1) is already done in #108

By the way, I don't think kosogor should be removed, since I don't see any reasons its functionality should be written manually in the build files.