Cole Faust

Results 25 comments of Cole Faust

We plan to implement this in the android fork of n2 as well. We'd like to implement action sandboxing (ideally using nsjail) before remote execution, as that will allow us...

We discussed this in https://github.com/evmar/n2/pull/94, Evan was hesitant to add this behavior, and in my case, updating Android to not rely on it was simple enough.

In ninja, the variable lookup is recursive, and [has cycle detection](https://github.com/ninja-build/ninja/blob/b2ae865439b66382d4ec8b5402cb99598b43ed4c/src/graph.cc#L460), which is missing from this PR.

I'm also seeing this issue, my site isn't working after upgrading from 0.6.0 -> 0.7.1

`base_path = "foo"`. No slashes or anything.