Cole Faust

Results 25 comments of Cole Faust

After https://github.com/evmar/n2/pull/112, I tried disabling the line counting and wasn't able to observe a noticeable speedup.

I think it would be good if n2 had a kind of "capabilities" config file, where each little thing that could be stricter was a separate flag. "ninja compat" mode...

The external file for clean builds is just [heuristics](https://cs.android.com/android/platform/superproject/main/+/main:build/soong/cmd/soong_build/main.go;l=136;drc=8c0b11ef791f99e8d3ab1832477d204e907d37ac): There are some hardcoded action types that get high weighting by default, and then after that if the actions have above...

Evan, do you mind elaborating on why you don't want to split the file into chunks? Is it a concern about reduced performance due to searching for valid chunk boundaries...

Yeah, maybe it would be better if I completed a fork with all of android's requirements, then upstreamed afterwards. I was just somewhat hesitant to do that at first because...

I have a [WIP branch that implements multithreading](https://github.com/Colecf/n2/tree/multithreading) (without mmap), but it doesn't actually improve the load times at all. It does seem like parsing finishes faster, but there's a...

I think what I'm most hung up about is how most of configuration seems to resolve around constraint_values/settings, (toolchain resolution, --platforms and --host_platforms on the command line), but they are...

Thanks! I don't think this should change the security concerns.

+1 we're also seeing segfaults after updating libc to 0.2.154 with code [that uses posix_spawn directly](https://github.com/evmar/n2/blob/117dfc642a5c724b629dc0d4ab768278803d4395/src/process_posix.rs).