Cœur

Before starting to review the many changes... - we already have a usage of ssize_t from July 2022: #3416 - there is a (poor?) workaround from November 2012: 9effd65 ```...

StackOverflow says we can get ssize_t with: ``` #if !defined(_XOPEN_SOURCE) && !defined(_POSIX_C_SOURCE) #define _XOPEN_SOURCE 700 #endif #include #if defined(_MSC_VER) #include typedef SSIZE_T ssize_t; #else #include #endif ``` Would that work?...

Crash log says it happened in: https://github.com/transmission/transmission/blob/cdf817f2e7f090b0851480b95ce217fab9ae1132/macosx/ShareTorrentFileHelper.mm#L39

The line of code in the crash log could be roughly this one (eventually a +/- a few lines): https://github.com/transmission/transmission/blob/cee339e10de6a1a41a086892af11c9ccfe5f3a68/libtransmission/peer-io.cc#L1119 Wait... https://github.com/transmission/transmission/commit/cee339e10de6a1a41a086892af11c9ccfe5f3a68 is from 2 months ago... why are you...

Can you share a crash log with the correct build number? Just to confirm the guilty line of code more precisely if possible.

@ckerr would be a crash in the place you've just refactored: https://github.com/transmission/transmission/blob/cdf817f2e7f090b0851480b95ce217fab9ae1132/libtransmission/peer-io.cc#L999 Maybe `gotError` is null?

@ckerr I got the line number from Gary's previous crash report, that I downloaded before his edit.

@GaryElshaw - if from cmake, be sure to include `-DCMAKE_BUILD_TYPE=RelWithDebInfo`: https://github.com/transmission/transmission/blob/d5ef1ea80a213f9adc6ef897e65d110406084657/docs/Building-Transmission.md?plain=1#L25 - if from Xcode, edit your scheme and be sure to build for `Debug` instead of Release.

@sweetppro @nevack OK change or not OK?

Actually, it's a duplicate of #4068, just I'm experiencing it on macOS app, while @belovachap experienced it on GTK.