Cœur

Results 652 comments of Cœur

We only need to do a basic implementation (well, that covers the features of the existing QuickLook plugin), and other changes or additions can be done in later pull requests...

We're still missing a unit test to verify that it works consistently, but the code looks good.

@nevack I know. I wrote it in my second paragraph: >So we could restrict the fix to just libevent and libdeflate, but I preferred to be consistent and apply it...

@nevack do we agree with my PR? It's actually the same when building with cmake: there are no special rules just for deflate and event; all third-parties are linked independently.

@ckerr This one is good to merge too, thanks.

4.0.0-beta.1.dev was 22 days ago, while cee339e10de6a1a41a086892af11c9ccfe5f3a68 was 60 days ago, so something is odd with your setup.

I'm not facing this issue: ![Capture d’écran 2022-11-01 à 17 36 18](https://user-images.githubusercontent.com/839992/199204549-0ac135d3-08c2-45ca-b2c7-21255263ed45.png) How did you build the app? Can you try to clean your build folder, delete the app and...

@chaseholden @Tockman if you can build from source, and if you somehow are able to reproduce the issue semi-consistently, can you try to add this declaration in FilterButton.mm? ``` -...

As I can't reproduce the issue myself, I can't certify the origin of the issue or how to fix it. Another possibility: maybe it's caused by the vertical line which...