Cody Bennett

Results 360 comments of Cody Bennett
trafficstars

I know with Lerna we could use symlinks to locally include private packages in a namespace. Maybe there's an equivalent with Preconstruct.

Can we point this to v8? Do note that `is` is a bit sensitive as it's used to diff within the reconciler. This duplication might've been intentional, but we can...

I ended up removing `is` from RTTR in #2465. It was only needed to null-check an array argument and I don't foresee it being useful elsewhere -- diffing is internal...

Continuing scene/inject discussion in #2142.

This looks to be implemented with #2153 of v8, but happy to re-open if anything comes up.

Is the expectation for `state.viewport` to be reactive? Otherwise, this looks correct unless you want width and height to be scaled with factor -- the semantics shouldn't change though.

I see two issues here: - `viewport` isn't representative of the gl viewport/drawbuffer size - updating the drawbuffer size independently of the DOM size; again, they're separate IMO it's best...

What's the resolution here? Can we use a name like `container` to consolidate information about the canvas container or move the three/viewport units elsewhere? I think it's confusing to reduce...

I think we're in agreement, but maybe for different reasons. To clarify my comment, yes, all graphics APIs define a viewport, and the use of the term is consistent throughout....

> I'm not sure if that's true. Checking through the links I posted above, it's: viewport = (xOffset, yOffset, width, height). Then all except OpenGL also include minZ and maZ...