Vincent Orr

Results 105 comments of Vincent Orr

I've converted the specs to something [readable](https://github.com/purescript/purescript-datetime/pull/80/files#diff-40ae3fd46bdee99ab746c3e979224626) but need some pointers as to what in the current tests might relate to the specs, also what new tests I might need....

would I be better off just setting up a whole new set of tests to make sure the library matches the specs? I'm slightly reluctant as naming differ and don't...

ah yeah that a much better plan than jump in replace everything lol. I'll set up some test to try mimic the specs 😄

After looking deeper into this, I'm finding it difficult to see the current implementation reflecting the ecma specs. Looking at the function Weekday: ```Javascript Day(t) = floor(t / msPerDay) msPerDay...

## 6.4 - **[Computing Bounding Rectangles](https://github.com/paf31/purescript-book/blob/master/text/chapter5.md#computing-bounding-rectangles)** > `class Eq a

Ha I've just hit this issue when trying to do a `GET` with headers (for auth token) but get the error ``` Error: TypeError: Failed to execute 'fetch' on 'Window':...

yeah seems that `window.fetch` wants no `body` 😢 https://github.com/whatwg/fetch/issues/551 This is a shame, I tried making body a `Maybe` locally, but when doing `body: Nothing` it still seems to add...

cool got it working, want me to create a PR?

what should we store inside the table `off_chain_vote_data` when we hit this new case (valid hash/failed parsing)? With the field `json` do we: 1. make it nullable 2. populate it...

@NanuIjaz did you manage to take a look at your postgres instance as advised?