purescript-datetime icon indicating copy to clipboard operation
purescript-datetime copied to clipboard

Published 20 hours ago • verified publisher icon purescript

Adding tests that cover the ecma262 specs

Open Cmdv opened this issue 4 years ago • 3 comments

Extending the tests to follow the JS Ecma262 specs for Date object.

  • [x] turn the specs into something reasonably readable
  • [ ] work out what tests need to be added/moved to cover these specs
  • [ ] potentially have TODO tests for non existent functionality

Cmdv avatar Sep 22 '20 16:09 Cmdv

I've converted the specs to something readable but need some pointers as to what in the current tests might relate to the specs, also what new tests I might need. As I'm not quite able to make the correlation between specs and current tests. 😄

Cmdv avatar Sep 22 '20 18:09 Cmdv

would I be better off just setting up a whole new set of tests to make sure the library matches the specs? I'm slightly reluctant as naming differ and don't want to take out tests that would be required, but I'm keen to keep things moving.

Cmdv avatar Sep 23 '20 15:09 Cmdv

Yeah, I'd just make new tests for the spec stuff, and have them live together/structured similarly to the spec so they can be easily compared with the spec. I don't think it does any harm to potentially have two tests for the same thing, if it so happens that some of the existing tests were covering the same aspects.

garyb avatar Sep 25 '20 10:09 garyb