evalai-cli icon indicating copy to clipboard operation
evalai-cli copied to clipboard

Define a generalized function for display_submission_*

Open hkmatsumoto opened this issue 5 years ago • 7 comments

Changes:

  • Define a generalized function for display_submission_*, since those functions will be very similar to each other.

hkmatsumoto avatar Jan 11 '20 08:01 hkmatsumoto

@takitsuse I think what @vkartik97 meant was using a single submission_result util function to extract all useful content. Adding a new argument in the function i.e. display_submission_result(submission_id, file_name) where file_name can be stdout, stderr etc. Currently, we have all the implementation in utils and using it as a wrapper in the root directory for click library.

pushkalkatara avatar Jan 11 '20 10:01 pushkalkatara

Okay, is @pushkalkatara's comment what you ment @vkartik97?

hkmatsumoto avatar Jan 11 '20 11:01 hkmatsumoto

Okay, is @pushkalkatara's comment what you ment @vkartik97?

Yes 💯

krtkvrm avatar Jan 12 '20 13:01 krtkvrm

Defined a generalized function as @pushkalkatara's proposal. @vkartik97 Could you take another look?

hkmatsumoto avatar Jan 12 '20 13:01 hkmatsumoto

Can you please fix the travis build?

krtkvrm avatar Jan 12 '20 13:01 krtkvrm

@vkartik97 Fixed :+1:

hkmatsumoto avatar Jan 12 '20 13:01 hkmatsumoto

Should I merge this change to https://github.com/Cloud-CV/evalai-cli/pull/252?

hkmatsumoto avatar Jan 12 '20 13:01 hkmatsumoto