Fabrik icon indicating copy to clipboard operation
Fabrik copied to clipboard

Share button should be disabled when canvas is empty

Open gautamjajoo opened this issue 5 years ago • 5 comments

Observed Behaviour

One can get a shareable link if the canvas is empty.

Expected Behaviour

The share button should be disbaled

Would you like to work on it?

Yes

@Ram81

capture

gautamjajoo avatar Nov 19 '18 07:11 gautamjajoo

@gautamjajoo sure go ahead.

Ram81 avatar Nov 19 '18 15:11 Ram81

Is there a current pull request regarding this feature request?

rshrc avatar Dec 13 '18 13:12 rshrc

@rshrc No, I haven't opened a PR yet, will be doing in some time.

gautamjajoo avatar Dec 13 '18 13:12 gautamjajoo

@gautamjajoo I was learning React, and thought of this as an easy issue, can I work on it? Maybe you can walk me through on how to go about it? I'll get familiar with the code base on the way. If possible obviously.

rshrc avatar Dec 13 '18 13:12 rshrc

@rshrc Ok, you can work on it!

gautamjajoo avatar Dec 13 '18 13:12 gautamjajoo