Fabrik icon indicating copy to clipboard operation
Fabrik copied to clipboard

Published 20 hours ago • verified publisher icon Cloud-CV

Fix #316

Open namish800 opened this issue 5 years ago • 8 comments

*Added CapsNet in model zoo as requested in issue #316 . *Added support for CapsuleLayer under vision category. *Added support for MaskCapsule layer and Length layer under Utility category. *Added support for Squash layer under Activation category

namish800 avatar Oct 31 '18 22:10 namish800

@namish800 Can you also share a screenshot of imported model?

Ram81 avatar Nov 04 '18 05:11 Ram81

screenshot from 2018-11-04 12-51-22

namish800 avatar Nov 04 '18 07:11 namish800

@namish800 can you resolve the conflicts and fix the issue with number of parameters.

Ram81 avatar Nov 05 '18 09:11 Ram81

@Ram81 I added the shape calculation logic for new layers. Now input and output shapes are correct but it is not counting number of parameters of only Capsule Layer now. I am currently trying to solve this then I will get to resolving the conflicts.

namish800 avatar Nov 05 '18 09:11 namish800

I still can't figure out how does calculate_parameter function in ide/views.py works. Can you help me figure out how this function is calculating number of parameters.

namish800 avatar Nov 05 '18 09:11 namish800

@namish800 can you test the export functionality of the model and mention it in readme also can you write import & export test for the same.

Ram81 avatar Nov 06 '18 12:11 Ram81

@Ram81 I have tested the export functionality of the model and mentioned about it in the readme file. if I am right I have to write the tests in Fabrik/tests/unit/keras_app/test_views.py ?

namish800 avatar Nov 06 '18 12:11 namish800

@namish800 yes you have to write tests there until we have a separate test suite for celery tasks.

Ram81 avatar Nov 07 '18 10:11 Ram81