Fabrik icon indicating copy to clipboard operation
Fabrik copied to clipboard

Fix #317: Added multiple layer deletion functionality to action bar

Open yashdusing opened this issue 6 years ago • 16 comments

Adding multiple layer functionality

yashdusing avatar Mar 17 '18 18:03 yashdusing

Coverage Status

Coverage remained the same at 95.442% when pulling 532bd5625550aa4d1a6a73a60178a8dd94aa9512 on yashdusing:multiple_deletion into c3947686d95c89d643b51a5b5c3be8d93f28476b on Cloud-CV:master.

coveralls avatar Mar 17 '18 18:03 coveralls

@yashdusing can you post a screenshot of how it works?

Ram81 avatar Mar 18 '18 05:03 Ram81

Step 1 : Load model & select the layer you want to delete. Add to the delete queue screenshot from 2018-03-18 11-26-22 Step 2 : Repeat for the layers to be deleted Step 3 : Empty the delete queue screenshot from 2018-03-18 11-26-51 Output : (Deleting first 3 layers) screenshot from 2018-03-18 11-27-04

yashdusing avatar Mar 18 '18 06:03 yashdusing

@thatbrguy @Ram81 could you please review the changes made ?

yashdusing avatar Mar 18 '18 06:03 yashdusing

Is this okay?

yashdusing avatar Mar 18 '18 18:03 yashdusing

@yashdusing Hey, I didn't have time to check it out, maybe @Ram81 could.

But from the screenshots, here are my comments:

  • The delete button is placed at the right place. Great!
  • Is there some highlighter that would indicate what layers are added to the delete queue ?
  • Have you tried doing it without a delete queue? As in, delete immediately after selection.

thatbrguy avatar Mar 19 '18 00:03 thatbrguy

I’ll add something to highlight the selected layers

yashdusing avatar Mar 19 '18 05:03 yashdusing

Wouldn’t that be the same as the delete button ?

yashdusing avatar Mar 19 '18 05:03 yashdusing

@yashdusing Hey, I tested your method, good work. I would still prefer if it was like the following:

  • Press the 'X' button
  • Click on any number of layers you want. The click itself either adds the layer to the queue, or deletes it
  • Press 'X' again when done

thatbrguy avatar Mar 19 '18 17:03 thatbrguy

I’ll work on the highlighting part first if it’s possible just to make this pr complete and then implement the above . Is that okay ?

yashdusing avatar Mar 19 '18 17:03 yashdusing

Your call. Take your time though, there's no rush.

thatbrguy avatar Mar 19 '18 17:03 thatbrguy

I thought about it for a while. There are 2 approaches : 1: Delete mode button which when activated deletes the layer selected instantly. 2: Delete Queue Add and Empty dropbox which when layer is added to queue, highlight is added to the layer and then selected layers are deleted. What approach do you think is appropriate? The instant delete or highlight ?

yashdusing avatar Mar 21 '18 03:03 yashdusing

@thatbrguy @Ram81

yashdusing avatar Mar 21 '18 14:03 yashdusing

@yashdusing Could you fix the PR message, you might have missed deleting the PR guidelines. As for the multiple delete function, could we have a delete option in the sidebar upon clicking which a checkbox pops next to each node, and all layers which have been checked can be deleted on the press of another button.

utsavgarg avatar Mar 21 '18 14:03 utsavgarg

@utsavgarg earlier PR did the same thing (except the checkbox button) you asked. But, I had to shift to the action bar :/.

yashdusing avatar Mar 21 '18 14:03 yashdusing

@yashdusing Sorry about the confusion, by the sidebar I did mean the one on the left (action bar).

utsavgarg avatar Mar 21 '18 15:03 utsavgarg