EvalAI icon indicating copy to clipboard operation
EvalAI copied to clipboard

Display Challenge ID, SQS Queue, IAM Credentials

Open vinceli1004 opened this issue 2 years ago • 4 comments

vinceli1004 avatar Oct 13 '21 07:10 vinceli1004

Codecov Report

Merging #3614 (d8ec419) into master (96968d6) will decrease coverage by 1.40%. The diff coverage is 33.39%.

@@            Coverage Diff             @@
##           master    #3614      +/-   ##
==========================================
- Coverage   72.93%   71.53%   -1.41%     
==========================================
  Files          83       20      -63     
  Lines        5368     3235    -2133     
==========================================
- Hits         3915     2314    -1601     
+ Misses       1453      921     -532     
Impacted Files Coverage Δ
frontend/src/js/controllers/authCtrl.js 53.91% <6.38%> (-12.95%) :arrow_down:
frontend/src/js/controllers/profileCtrl.js 79.76% <20.00%> (-13.10%) :arrow_down:
frontend/src/js/controllers/permissionCtrl.js 36.36% <22.22%> (-63.64%) :arrow_down:
frontend/src/js/controllers/challengeCtrl.js 63.54% <31.97%> (-10.15%) :arrow_down:
frontend/src/js/controllers/updateProfileCtrl.js 82.55% <44.44%> (-10.30%) :arrow_down:
frontend/src/js/controllers/challengeListCtrl.js 95.74% <50.00%> (+1.06%) :arrow_up:
...ntend/src/js/controllers/challengeHostTeamsCtrl.js 70.50% <66.66%> (-1.18%) :arrow_down:
frontend/src/js/controllers/teamsCtrl.js 71.17% <75.00%> (ø)
frontend/src/js/controllers/ChallengeInviteCtrl.js 100.00% <100.00%> (ø)
frontend/src/js/controllers/SubmissionFilesCtrl.js 95.45% <100.00%> (ø)
... and 69 more
Impacted Files Coverage Δ
frontend/src/js/controllers/authCtrl.js 53.91% <6.38%> (-12.95%) :arrow_down:
frontend/src/js/controllers/profileCtrl.js 79.76% <20.00%> (-13.10%) :arrow_down:
frontend/src/js/controllers/permissionCtrl.js 36.36% <22.22%> (-63.64%) :arrow_down:
frontend/src/js/controllers/challengeCtrl.js 63.54% <31.97%> (-10.15%) :arrow_down:
frontend/src/js/controllers/updateProfileCtrl.js 82.55% <44.44%> (-10.30%) :arrow_down:
frontend/src/js/controllers/challengeListCtrl.js 95.74% <50.00%> (+1.06%) :arrow_up:
...ntend/src/js/controllers/challengeHostTeamsCtrl.js 70.50% <66.66%> (-1.18%) :arrow_down:
frontend/src/js/controllers/teamsCtrl.js 71.17% <75.00%> (ø)
frontend/src/js/controllers/ChallengeInviteCtrl.js 100.00% <100.00%> (ø)
frontend/src/js/controllers/SubmissionFilesCtrl.js 95.45% <100.00%> (ø)
... and 69 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 6036d41...d8ec419. Read the comment docs.

codecov-commenter avatar Oct 29 '21 05:10 codecov-commenter

@Ram81 it says there's still some changes requested - I think I have addressed everything, just pinging you here so you can verify in case you missed it.

vinceli1004 avatar Dec 06 '21 23:12 vinceli1004

@vinceli1004 can we fix the alignment for the challenge queue name and add more padding between challenge id and queue name. We don't need to have a separate section for these details. These can go in the first section with all other details like challenge title, etc.

For queue name we should show just first 25 chars and show ... if queue name is longer with a copy button. You can find an example of the copy button on the profile page -> Get Auth token modal. Let me know if you have any doubts

Ram81 avatar Dec 08 '21 18:12 Ram81

@vinceli1004 there's a issue with the PR. The copy button is shown next to challenge id. We should show it next to sqs queue name and show full challenge id. We should show first 20 chars of sqs queue name. Another issue I saw is, when I click on the copy button it opens the edit terms and conditions popup. Can we fix these issues?

Screenshot from 2021-12-11 13-32-50

Ram81 avatar Dec 11 '21 18:12 Ram81