Philip Cohn-Cort
Philip Cohn-Cort
## Description This issue refers to [the CHANGELOG file](https://github.com/Estimote/Android-Proximity-SDK/blob/486f09f49d73e5ba048bd1/CHANGELOG.md). If you look closely at the top of that linked item, you will note that the entries for `1.0.4` and `1.0.5`...
We disabled the `MissingConstraints` Lint check a while ago, and just today I merged in #363 to disable `NotSibling` as well. These sorts of issues can (and do) break the...
This mostly just removes some duplicate code. There's also some better documentation of the various `All` fragments. This PR is on hold until #297 and #299 are merged in. It...
This corresponds to the problems we saw in #358 and #357 , under ticket AIC-646. Put simply, if we define then RxJava2 calls such as [this one](https://github.com/art-institute-of-chicago/aic-mobile-android/blob/92059159029f014c690797ba6e2c5c253db9e078/media_ui/src/main/java/edu/artic/media/ui/AudioDetailsFragment.kt#L153) sometimes fail to...
This codebase has changed a lot since the first commit. @sam33rdhakal and myself will undertake a basic audit, looking for the following things: - Code we don't understand - Duplicated...
# The issue As it stands at v1.0, there are some significant quantities of code duplication between * `WelcomeTourCellViewModel` and `AllToursCellViewModel` * `WelcomeEventCellViewModel` and `AllEventsCellViewModel` * `WelcomeExhibitionCellViewModel` and `AllExhibitionsCellViewModel` *...
### Expected behaviour Building a multiplatform gradle module with Gradle 7.2 and the Hagu plugin should not bring up any errors. ### Actual behaviour Executing a gradle build (in my...
`MainActivity::loadPreferences`, when we don't have an IP address, automatically opens the settings screen (`SettingsActivity`). This means that if the user opens this app for the first time, they will be...
While I don't see any need to switch directly to Kotlin now, I could see benefits in targeting a more recent version of the Gradle Wrapper (currently at 3.4) and...
As of cee0bc4db158, there are * 501 lines of java code * 357 lines of comments * 98 blank lines in `CutoutViewIndicator.java`. This seems a bit much. Could we get...