ClimaOcean.jl
ClimaOcean.jl copied to clipboard
CliMA
🌎 Ocean component for CliMa's Earth system model based on Oceananigans
Here's the docstring: https://github.com/CliMA/ClimaOcean.jl/blob/290951d823e8571740c3db6a55f31e822320d646/src/OceanSeaIceModels/CrossRealmFluxes/tabulated_albedo.jl#L53-L57 Here's what I suggest: ```julia # Make clear that the latitudes are specific to the tabulated albedo above const payne_latitude = (0:2:90) .* π / 180...
The index calculated here https://github.com/CliMA/ClimaOcean.jl/blob/290951d823e8571740c3db6a55f31e822320d646/src/OceanSeaIceModels/CrossRealmFluxes/tabulated_albedo.jl#L153 is not restricted to make sure that https://github.com/CliMA/ClimaOcean.jl/blob/290951d823e8571740c3db6a55f31e822320d646/src/OceanSeaIceModels/CrossRealmFluxes/tabulated_albedo.jl#L156 is inbounds I propose to add a fix like so ```julia nαx, nαy = size(α.α_table) j⁺ =...
Need to invoke `using ClimaOcean` during CI initialization to download artifacts / files to scratch
Otherwise we will redownload them in separate jobs. Related to #145
I am a bit puzzled by having ```julia similarity_theory = coupled_model.fluxes.turbulent ``` in this line https://github.com/CliMA/ClimaOcean.jl/blob/0cbb8a57838fbf2a11ed9991a1da2c21e487e131/src/OceanSeaIceModels/CrossRealmFluxes/atmosphere_ocean_fluxes.jl#L32 For me is a bit counterintuitive because `turbulent` can be a lot of things...
I'd like to start this discussion here. The README for [`Scratch.jl`](https://github.com/JuliaPackaging/Scratch.jl) states: > Because the scratch space location on disk is not very user-friendly, scratch spaces should, in general, not...
As discussed on #126, we need to have a way of assessing performance regressions and changes within CI, ideally in an efficient manner (sub 1 hour as per our usual...
As discussed on #126, we currently only have the long-running example to test the performance and correct behavior of the code. However, the example takes 4 hours to run and...
There are few tests for bathymetry utilities. Here are a few that we need: 1. Unit tests that ensure the functions run without an error, also testing conditions like: a....
It appears twice in `examples_build.yml`: https://github.com/CliMA/ClimaOcean.jl/blob/ad28ba8acca2ecff7ab94f25ffb0a72e0ae3429a/.buildkite/examples_build.yml#L7 https://github.com/CliMA/ClimaOcean.jl/blob/ad28ba8acca2ecff7ab94f25ffb0a72e0ae3429a/.buildkite/examples_build.yml#L54 @simone-silvestri
Apparently, the documentation does not build on the main, but only on PRs when adding the `Run Example` label. These are the steps in the buildkite settings ``` steps: -...