Claire

Results 1010 comments of Claire

> Ah, okay! So, this does currently work for instance-level domain blocks, but account search does not take into account user-level domain blocks (or even user-level account blocks). I'm not...

I'm not too sure how a service worker would cause issues with refreshes but not with another tab. That being said, it still seems possible. When that happens, am I...

> Alas, as the page failed to load yet again, my inspector's application tab shows nothing, And clicking on "see all registrations" doesn't show what your example does, or anything...

This amount of warning messages is pretty weird, and makes me think perhaps Chrome has a lot of work to catch up to when you switch back to the tab?

> I've been seeing something similar in Chrome for a few weeks now. Just a blank page, while Firefox loads correctly. The console messages suggest something is going wrong with...

The code looks fine, and I thought I liked the idea, which can help with at least the onboarding page, but upon testing: - it does feel distracting, especially on...

> Also, I'm a bit worried about https://guides.rubyonrails.org/upgrading_ruby_on_rails.html#key-generator-digest-class-changing-to-use-sha256 as I don't see it being addressed in this PR. It indeed logged me out when testing it in a production environment.

Using `:hybrid` and a rotator for a few releases seem like the best course of action. There's `cookies.signed['_session_id']` but also just the encrypted-cookie-backed session store managed by Rails.

Thanks for your work on this! The key rotator seems to work, I've merged the PR on my single-user server and did not notice any issue yet. I believe this...

A behavior change I just noticed is IIRC, `assets:precompile` used to install yarn dependencies before running `webpack`, but that does not seem to happen anymore. This is because railties dropped...