Claudio Salvatore Arcidiacono

Results 22 comments of Claudio Salvatore Arcidiacono

> @ClaudioSalvatoreArcidiacono I think this is a great idea and will make RFE much more useful. How is the PR going? > > FWIW this is a way to overcome...

Hey @Micky774, thanks a lot for reviewing my PR and for leaving your suggestions! I have updated the PR accordingly.

> Hey @marenwestermann, hope you don't mind if I chime in :). > > I noticed that you missed 2 `random_state`, one at line `191` and another line `210`. Rather...

#175 I am proposing a fix for this issue, feedback is welcome, be kind this is my first contribution :)

Hi @Micky774, thanks a lot for your comments! Now I better understood the purpose of this change. I have reviewed the tests and I have left the hardcoded seed values...

If you want ColumnTransformer to return a Dataframe you can do it using the method [set_output](https://scikit-learn.org/stable/modules/generated/sklearn.compose.ColumnTransformer.html#sklearn.compose.ColumnTransformer.set_output) For example: ```python from sklearn.feature_extraction import FeatureHasher from sklearn.preprocessing import MinMaxScaler import pandas as...

> @ClaudioSalvatoreArcidiacono please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information. > > ``` > @microsoft-github-policy-service agree [company="{your company}"] >...

Hey @jameslamb thanks for picking this up. I have started to take a look at the ci failures, I think I can solve most of them easily. There is one...

Hey @jameslamb, I did not have much time to take a look at this lately, I should be more available now and in the coming weeks. If you also have...

Hey @jameslamb, no problem. Thanks for being transparent on your availability on this PR and for your feedback. I followed it and I made the PR easier to review now....