Adrian Kunz

Results 80 comments of Adrian Kunz

`2015Y-01M-15D` seems like a strange date format. Why not go for ISO 8601? E.g. `2015-01-15` or `2015-01-15T12:34:56` or `2015-01-15T12:34:56.789` depending on precision.

Looks like this is the line that causes it: https://github.com/arut/nginx-dav-ext-module/blob/f5e30888a256136d9c550bf1ada77d6ea78a48af/ngx_http_dav_ext_module.c#L865 Perhaps there should be a flag that toggles this? I'd submit a PR but I don't know enough about nginx...

In addition, that PR was a breaking change. @NoNameProvided

Why not combine the filter operations to save an intermediate array creation?

In addition I would even argue that the parseInt should be guarded with typeof value === 'string' instead of !== function because that is the assumption of `as string` in...

@SimonRosenau Thanks for addressing! I believe you don't need it anymore. See https://stackoverflow.com/a/43091709/4138801 > ```ts > Object.keys(myEnum).map(key => myEnum[key]).filter(value => typeof value === 'string') as string[]; > ``` Or with...

I can't, Im not a maintainer

Why when you can just combine `@IsInt` and `@IsPositive`?