Adrian Kunz

Results 80 comments of Adrian Kunz

Hi @parrt , #235 should be ready for merging, #237 is awaiting changes from @sharwell , and I'm nearly done with this one. I also started work on a PR...

Update: this PR is now ready to be merged from my side, please review! Although there are many changes, it should be done quite quickly because they are small and...

This PR doesn't need to be in the coming release. Most of the changes are small and improve code quality, some might improve performance slightly. But still, I'd really like...

You should adhere to the code style (in particular, tabs vs spaces). There are currently way more changed lines than need be.

Hm, treating all characters as indentation is problematic in cases like this: ``` /** * @param value */ ``` Treating ` * @param value ` as indentation could create something...

@NamTranHong maybe you want something like this? ``` type(type) ::= typeTemplate(type) ::= type_NamedType(type) ::= type_ArrayType(type) ::= type_ListType(type) ::= type_MapType(type) ::= type_OptionalType(type) ::= ```

What is the use case? Pagination comes to mind, but that also requires a way to skip `n` items.

Did you try the latest version [4.3.1](https://github.com/antlr/stringtemplate4/releases/tag/4.3.1)?

Yes, sorry for the delayed answer 😢 I am working hard to finish this PR off, imo it is the most important one because the earlier these deprecations are in,...